1999 wj will not start

Im trying to get my 99 wj back on the road after a long winter without it.  i started the motor the other day and heard a knocking coming from the engine bay.  i knew it had a faulty ignition coil so i replaced that, put some high test gas in it and changed the oil with mobile 1 synthetic as well as added some lucas oil to the mix.  started up fine last night after the work was done still had the knock... now the next day the motor wont even start... any ideas?  id like to get it started first then worry about the knock. it seems as tho i have no spark at the engine, and i can hear the fuel pump come on.  the starter engages but the engine does not fire.  any help would be appreciated.